the master branch still has the old makefiles I guess, so, look at the
master branch if need reference.
update sst1 makefiles to store the libs under individual sst1 and sst96
directories.
update linux makefiles for XPATH variable usage.
rename makefile.linux to Makefile.linux under the tests directories.
sbench.c:300: error: lvalue required as left operand of assignment
sbench.c:301: error: lvalue required as left operand of assignment
sbench.c:375: error: lvalue required as left operand of assignment
sbench.c:376: error: lvalue required as left operand of assignment
I _think_ this is the correct fix: MSVC6 generates the same output
before and after this patch.
fix wrong error check in SimpleRleDecode() (thanks gcc -Wsign-compare).
fix some old wrong warning fixes in glide2x tree.
also remove ctype.h dependency and use a generic strupr().
commit 4b63afa8 by jwrdegoede added fread() checks like:
if(fread(buf,size,nelem,fp) != size*nelem) error();
however the check must be against nelem alone, and _not_
the total bytes.
Building glide3x/cvg, gcc emits the following warning:
gglide.c: In function `grBufferClear':
gglide.c:733: warning: suggest parentheses around arithmetic in operand of |
... but glide2x/cvg is silent for it, because commit df4085a80 from
about 18 years ago added parentheses to silence it, like:
GR_SET(BROADCAST_ID, hw, bltSize,
- ( ((((tileHi - tileLow) * gc->hwDep.cvgDep.xTilePages) - 1) << 16) | (0x1000 >> 3) - 1));
+ ((((((tileHi - tileLow) * gc->hwDep.cvgDep.xTilePages) - 1) << 16) | (0x1000 >> 3)) - 1));
... which seems wrong. Substraction has precedence, therefore the
original code OR'ed the size by 511, but the fixed code OR'ed the
size by 512 and then substracted 1 from the result.
Looking at sst1InitVideoBuffers() init/video.c: it sets sst->bltSize
like:
ISET(sst->bltSize, ((pagesToFill-1)<<16) | 511);
Therefore, reverting this part of df4085a80 now. We can live with the
warning.
gglide.c: In function `grAlphaCombine':
gglide.c:337: warning: suggest explicit braces to avoid ambiguous `else'
gglide.c: In function `grColorCombine':
gglide.c:917: warning: suggest explicit braces to avoid ambiguous `else'
